feature / #68 skip running checks if file content has not changed#72
Open
davidramnero wants to merge 3 commits into
Open
feature / #68 skip running checks if file content has not changed#72davidramnero wants to merge 3 commits into
davidramnero wants to merge 3 commits into
Conversation
danmar
reviewed
Jun 17, 2026
| return; | ||
| } | ||
|
|
||
| if ((Object.keys(documentHashMemory) as Array<string>).includes(document.fileName)) { |
Contributor
There was a problem hiding this comment.
can there be some situation when results are not shown for a file and user wants to save to trigger analysis? is cppcheck always executed when a file is opened? even if user doesn't open the file but vscode opens the file automatically during startup or something?
Collaborator
Author
There was a problem hiding this comment.
Yeah this is a good question, I am trying to think of a way to make it safe from ending up in a kind of stuck mode such as you describe, but I am not sure we can be completely safe from it happening.
Maybe this feature isn't worth the risk?
Collaborator
Author
There was a problem hiding this comment.
I am not sure how much of a problem it is to run checks a little more than necessary tbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.